Fix resolving a tsconfig directory to a file path#513
Fix resolving a tsconfig directory to a file path#513bradleyayers wants to merge 1 commit intomdx-js:mainfrom
Conversation
When a project is configured with its tsconfig pointing to a directory rather than a file, it needs to be resolved to a file before trying to read the contents of the file. Fixes mdx-js#481. I've raised this as an upstream issue too via volarjs/volar.js#283.
|
|
Hi! It seems some of the things asked in the template are missing? Please edit your post to fill out everything.
You won’t get any more notifications from me, but I’ll keep on updating this comment, and remove it when done! If you need it, here’s the original template<!--
Please check the needed checkboxes ([ ] -> [x]).
Leave the comments as they are: they do not show on GitHub.
Please try to limit the scope,
provide a general description of the changes,
and remember it’s up to you to convince us to land it.
We are excited about pull requests.
Thank you!
-->
### Initial checklist
* [ ] I read the support docs <!-- https://mdxjs.com/community/support/ -->
* [ ] I read the contributing guide <!-- https://mdxjs.com/community/contribute/ -->
* [ ] I agree to follow the code of conduct <!-- https://github.com/mdx-js/.github/blob/main/code-of-conduct.md -->
* [ ] I searched issues and discussions and couldn’t find anything or linked relevant results below <!-- https://github.com/search?q=user%3Amdx-js&type=issues and https://github.com/orgs/mdx-js/discussions -->
* [ ] I made sure the docs are up to date
* [ ] I included tests (or that’s not needed)
### Description of changes
TODO
<!--do not edit: pr-->
Thanks, |
|
This issue needs to be fixed upstream, on the other hand if #512 is completed then this issue will no longer need to be dealt with. |
2 participants
Initial checklist
Description of changes
When a project is configured with its tsconfig pointing to a directory rather than a file, it needs to be resolved to a file before trying to read the contents of the file.
Fixes #481.
I've raised this as an upstream issue too via
volarjs/volar.js#283.